fix: Graphical issues with tint_config implementation#8211
Merged
chaosvolt merged 5 commits intocataclysmbn:mainfrom Feb 20, 2026
Merged
fix: Graphical issues with tint_config implementation#8211chaosvolt merged 5 commits intocataclysmbn:mainfrom
chaosvolt merged 5 commits intocataclysmbn:mainfrom
Conversation
Collaborator
|
I'm going to swap the post processing fields to be non-optional as well, but I need to handle other stuff. |
AzmodiusX
approved these changes
Feb 20, 2026
Collaborator
AzmodiusX
left a comment
There was a problem hiding this comment.
Everything seems to work perfectly.
My additions were minor, so I'll approve
But I'll let someone else merge, just in case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Fix graphical issues introduced by #8026
Describe the solution (The How)
tint_configmade use ofstd::optional<SDL_Color>,but std::nulloptandTILESET_NO_COLORevaluated to different tiles (hash mismatch), when they should be the same, causing issues with dynamic tile lookupDescribe alternatives you've considered
N/A
Testing
Load Game
Change Tileset (e.g UltiCa) when the game is open
or Debug - Reload Tileset
Additional context
Note: Reloading/Changing the Tileset at z-level != 0 has its own issues, unrelated to this PR, and will be dealt with later.Aditionally:
Are prone to the same issue, and should also be changed to be always present values, with bias (-1 ~ 1 range), and 0 being treated as no-op like TILESET_NO_COLOR
Tagging @AzmodiusX for this
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.