build: gate debug prefix map to GitHub Actions#8215
Closed
scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
Closed
build: gate debug prefix map to GitHub Actions#8215scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
Conversation
Member
Author
|
on second thoughts, reverting this changes cause LLDB in local linux to not work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Regression from #7678 remapped local debug file paths to build-dir-relative paths, which breaks IDE/GDB breakpoints in local builds.
Describe the solution (The How)
Apply
-ffile-prefix-map=${REL_SRC_PATH}=.only when running on GitHub Actions (GITHUB_ACTIONSis set), while keeping local debug symbols mapped to real source paths.Describe alternatives you've considered
-ffile-prefix-mapentirely (keeps local debugging but drops CI/worktree ccache path normalization).Testing
cmake --preset linux-full -DLUA_DOCS_ON_BUILD=OFFcmake --build --preset linux-full --target cataclysm-bn-tiles cata_test-tiles./out/build/linux-full/tests/cata_test-tiles "time_duration_to_string"ffile-prefix-mapinout/build/linux-full/compile_commands.jsonin local env.Additional context
LUA_DOCS_ON_BUILDwas disabled for local verification because docs generation in this environment expects a root-level./cataclysm-bn-tilespath and fails post-link.Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.Optional
docs/folder.