Skip to content

feat(balance): non-external plane wings dont increase vic height#8218

Merged
chaosvolt merged 3 commits intocataclysmbn:mainfrom
AutumnNova:carbonspelling
Feb 21, 2026
Merged

feat(balance): non-external plane wings dont increase vic height#8218
chaosvolt merged 3 commits intocataclysmbn:mainfrom
AutumnNova:carbonspelling

Conversation

@AutumnNova
Copy link
Contributor

@AutumnNova AutumnNova commented Feb 21, 2026

Purpose of change (The Why)

Currently, adding any non-external plane wing to your aircraft increases the height and drag of your aircraft.
This means the best aircraft design in terms of air drag can only use external wings, as they increase the lift coeff without the 0.3 air drag penalty and 0.2 height penalty

This is very unintuitive compared to how a player is likely going to try and build an aircraft, so reasonably this check should either be applied to both internal and external wings, or neither
I have opted for neither

Describe the solution (The How)

Make non-external wings not count for the turret height increase check

Also fixes two name/description typos on carbon parts

Describe alternatives you've considered

Instead making external wings count for the turret height check too?
(would really fuck over planes, probably a bad idea)

or write a seperate check that increases the airdrag for all wings on the vic?
(realistically wing airdrag would increase significantly with airspeed but we dont bother to simulate that at all, it might also make planes terrible compared to the already very strong blimps, I dunno)

Testing

load the game, added a non-external plane wing to my aircraft and see that the aircoeff hasnt almost just doubled

Additional context

this changes the air drag for the small 2 seater plane from 0.74 to 0.42, which is a significant change, however you can easily reach that in current stable/nightly by just removing the 3 non-external wings

I also dont know if fix: or feat(balance): is a better scope for this pr
arguably it is a bugfix because either turret penalties shoudnt be applying to non-external wings or external wings should be impacted by turret penalties
but it also impacts the balance if you happened to be a player who used non-external wings at all

Checklist

Mandatory

@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. labels Feb 21, 2026
@AutumnNova AutumnNova changed the title balance: non-external plane wings dont increase vic height feat: non-external plane wings dont increase vic height Feb 21, 2026
@autofix-ci
Copy link
Contributor

autofix-ci bot commented Feb 21, 2026

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@AutumnNova AutumnNova changed the title feat: non-external plane wings dont increase vic height fix: non-external plane wings dont increase vic height Feb 21, 2026
@AutumnNova AutumnNova changed the title fix: non-external plane wings dont increase vic height feat(balance): non-external plane wings dont increase vic height Feb 21, 2026
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awawawa

@chaosvolt chaosvolt merged commit ecb0556 into cataclysmbn:main Feb 21, 2026
24 checks passed
@AutumnNova AutumnNova deleted the carbonspelling branch February 21, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JSON related to game datas in JSON format. src changes related to source code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants