feat(balance): non-external plane wings dont increase vic height#8218
Merged
chaosvolt merged 3 commits intocataclysmbn:mainfrom Feb 21, 2026
Merged
feat(balance): non-external plane wings dont increase vic height#8218chaosvolt merged 3 commits intocataclysmbn:mainfrom
chaosvolt merged 3 commits intocataclysmbn:mainfrom
Conversation
Contributor
|
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Currently, adding any non-external plane wing to your aircraft increases the height and drag of your aircraft.
This means the best aircraft design in terms of air drag can only use external wings, as they increase the lift coeff without the 0.3 air drag penalty and 0.2 height penalty
This is very unintuitive compared to how a player is likely going to try and build an aircraft, so reasonably this check should either be applied to both internal and external wings, or neither
I have opted for neither
Describe the solution (The How)
Make non-external wings not count for the turret height increase check
Also fixes two name/description typos on carbon parts
Describe alternatives you've considered
Instead making external wings count for the turret height check too?
(would really fuck over planes, probably a bad idea)
or write a seperate check that increases the airdrag for all wings on the vic?
(realistically wing airdrag would increase significantly with airspeed but we dont bother to simulate that at all, it might also make planes terrible compared to the already very strong blimps, I dunno)
Testing
load the game, added a non-external plane wing to my aircraft and see that the aircoeff hasnt almost just doubled
Additional context
this changes the air drag for the small 2 seater plane from 0.74 to 0.42, which is a significant change, however you can easily reach that in current stable/nightly by just removing the 3 non-external wings
I also dont know if fix: or feat(balance): is a better scope for this pr
arguably it is a bugfix because either turret penalties shoudnt be applying to non-external wings or external wings should be impacted by turret penalties
but it also impacts the balance if you happened to be a player who used non-external wings at all
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.