feat(UI,port): Streamline the repair interface to show repair/improvement/damage chance during item selection#8221
Merged
chaosvolt merged 6 commits intocataclysmbn:mainfrom Feb 24, 2026
Conversation
Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru> Co-authored-by: anoobindisguise <56016372+anoobindisguise@users.noreply.github.com> Co-authored-by: Alexey <irwiss@users.noreply.github.com>
Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru> Co-authored-by: anoobindisguise <56016372+anoobindisguise@users.noreply.github.com> Co-authored-by: Alexey <irwiss@users.noreply.github.com>
Contributor
|
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
Contributor
Author
Contributor
WishDuck
reviewed
Feb 22, 2026
src/game_inventory.cpp
Outdated
| return; | ||
| } | ||
| listed_components.emplace( component_id ); | ||
| if( item::count_by_charges( component_id ) ) { |
Collaborator
There was a problem hiding this comment.
Perhaps cache the charges for the duration of the function?
That should bring performance issues down to a minimum as most things are repaired with the same things
Contributor
Author
There was a problem hiding this comment.
Implemented, this does cut the waiting time noticably.
chaosvolt
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Purpose of change (The Why)
Port repair menu UX improvements from DDA so we shows repair details directly in the selection UI without having to go through to each item.
Related DDA PRs:
CleverRaven/Cataclysm-DDA#59827
CleverRaven/Cataclysm-DDA#65846
CleverRaven/Cataclysm-DDA#63587
Describe the solution (The How)
MATERIALS AVAILABLESUCCESSDMGDescribe alternatives you've considered
can_repair_target()in the menu filter to hide more invalid entries.Testing
Additional context
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.Optional
portscope to the PR title.Co-Authored-Byin the commit message.