feat: cloning improvements, NPC clones#8249
Draft
shmakota wants to merge 2 commits intocataclysmbn:mainfrom
Draft
feat: cloning improvements, NPC clones#8249shmakota wants to merge 2 commits intocataclysmbn:mainfrom
shmakota wants to merge 2 commits intocataclysmbn:mainfrom
Conversation
Contributor
|
This is exciting stuff. Looking forward to seeing how this could play out in future mission lines! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
You currently can't clone NPCs, but can clone everything else.
There's also some weird behavior with cloning-related content, this aims to mitigate some of that. Also cleans up some backend stuff related to cloning and extra item variables.
Describe the solution (The How)
Allows NPCs to be cloned. (to-do: require multiple samples or something, increase cloning time) Clones will copy gender, age, height, all traits that aren't specifically marked to be shed upon cloning or background traits, and physical stats at the time of cloning. Skills aren't copied as they are assumed to be learned, while stats are assumed to be physical improvements (maybe we can handwave it with some blob magic).
Swaps a few things over to use the requirements system, which makes using cloning vats with nearby items on the ground much cleaner and more straightforward.
Cloning stuff can be hard to understand for the survivor at the moment. Add some snippets and other hints towards it & how it functions in game. (to-do)
Describe alternatives you've considered
Not copying stats, or gender, etc. This can all be debated upon.
Testing
Do the generic cloning routine, but target an NPC or yourself. Confirm a clone pops out.
Additional context
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.