feat(lua): migrate achievements runtime to Lua#8263
Draft
scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
Draft
feat(lua): migrate achievements runtime to Lua#8263scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
Conversation
Assisted-by: openai/gpt-5.3-codex on opencode Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Describe the solution (The How)
data/json/achievements.luaruntime, wired throughdata/json/preload.luaanddata/json/main.lua.src/catalua_bindings_game.cppand Lua UI text bridge insrc/catalua.cpp/src/catalua.h.src/scores_ui.cpp; removed C++ tracker event subscription/save serialization usage insrc/game.cppandsrc/savegame.cpp.lua_achievements_runtimecoverage intests/catalua_test.cpp.Describe alternatives you've considered
Testing
cmake --build build --target astylecmake --build build --target style-json-paralleldeno task dprint fmtcmake --preset linux-fullcmake --build --preset linux-full --target cataclysm-bn-tiles cata_test-tiles./out/build/linux-full/tests/cata_test-tiles "lua_achievements_runtime"./out/build/linux-full/tests/cata_test-tiles "achievements_tracker"./out/build/linux-full/src/cataclysm-bn-tiles --check-mods(fails due local external user mods unrelated to this PR)Additional context
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.Optional
docs/folder.lang/bn_extract_json_strings.shscript if it does not support them yet.luascope to the PR title.deno task docs:genso the Lua API documentation is updated.