feat: Add item count based vehicle storage#8359
Open
WishDuck wants to merge 3 commits intocataclysmbn:mainfrom
Open
feat: Add item count based vehicle storage#8359WishDuck wants to merge 3 commits intocataclysmbn:mainfrom
WishDuck wants to merge 3 commits intocataclysmbn:mainfrom
Conversation
Contributor
❌ PR Title Validation Failedℹ️ How to fixYour PR title must follow the Conventional Commits specification. Check your repository's |
Contributor
|
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Describe the solution (The How)
Add a new way for item stacks to count storage: total charges
This limits storage to a certain number of charges
While it could be implemented in furnture, currently only implemented in vehicle land
Describe alternatives you've considered
Give up on balanced storage and give massive storage options because we want to be able to haul the one corpse
Let there be an total volume limit too?
Testing
Log truck works as expected
Additional context
I sadly did not ave a PR that reduced lines more then it added them today :(
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.Optional
docs/folder.