perf: Options Descriptions + Activity Bubble Resize Option#8361
Open
AzmodiusX wants to merge 6 commits intocataclysmbn:mainfrom
Open
perf: Options Descriptions + Activity Bubble Resize Option#8361AzmodiusX wants to merge 6 commits intocataclysmbn:mainfrom
AzmodiusX wants to merge 6 commits intocataclysmbn:mainfrom
Conversation
Contributor
|
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
continuation of #8252
Reality bubble size being set on game launch was annoying, and options were too verbose.
Additionally, activities lowering render distance seemed like a really good performance win.
Describe the solution (The How)
Made it so the reality bubble can be changed during gameplay.
Added option to change the reality bubble size wile doing any activity.
Added option to change the reality bubble size while in control of a vehicle (to help with travel lag).
Reduced complexity and length of various options.
Removed setting to batch out-of-bubble submap processing because it was based on an old idea for how the map overhaul would be structured.
Testing
Read, slept, and otherwise moved around.
Changed bubble size in settings.
Looked at text.