Skip to content

Plant explorer launch#30

Merged
krivard merged 6 commits intomainfrom
plant-explorer-launch
Mar 24, 2026
Merged

Plant explorer launch#30
krivard merged 6 commits intomainfrom
plant-explorer-launch

Conversation

@krivard
Copy link
Copy Markdown
Contributor

@krivard krivard commented Mar 20, 2026

Overview

Closes #29.

What did you change in this PR?

  • issue checklist (see Fix plant explorer launch blockers #29)
  • replaced long-lifetime if/else statements with judicious use of mo.stop
  • removed generator filters & related furniture if the plant has only one generator
  • minor whitespace opinions

Testing

How did you make sure this worked? How can a reviewer verify this?

Ran locally. Some good test plants:

  • CO / Adams / Cherokee for multiple generators where all have generation data available
  • WA / King / University of Washington for multiple generators where only a subset have generation data available
  • CO / Boulder / Boulder Canyon Hydro (55932) for maximum unavailable data (no plant gen, no generator gen, no generator attributes)
  • CO / Boulder / Jack's Solar Garden for single-generator case

To-do list

  • Update relevant documentation - like comments, docstrings, README, release notes, etc.
  • Review the PR yourself and call out any questions or issues you have

@krivard krivard self-assigned this Mar 20, 2026
@krivard krivard moved this from New to In progress in Catalyst Megaproject Mar 20, 2026
@krivard krivard moved this from In progress to In review in Catalyst Megaproject Mar 20, 2026
@cmgosnell cmgosnell self-requested a review March 23, 2026 17:23
Copy link
Copy Markdown
Member

@cmgosnell cmgosnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tinsy suggestions but nothing blocking for me! looks so good!

Co-authored-by: Christina Gosnell <cgosnell@catalyst.coop>
@krivard krivard merged commit 89049df into main Mar 24, 2026
2 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Catalyst Megaproject Mar 24, 2026
@krivard krivard deleted the plant-explorer-launch branch March 24, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fix plant explorer launch blockers

2 participants