Upload changes #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

keevan merged 8 commits into MOODLE_403_STABLE from 269-upload-handle-headers

Dec 18, 2025

Contributor

matthewhilton commented Nov 11, 2025

2 somewhat related CSV upload changes:
Closes #269
Closes #270

Changes

Improve docs and handling of optional headers. I believe before they were optional in the sense that the headers must be there, but the values could be empty. Now, you don't need to include the column at all.
Be able to book directly into an attendance status.
1. Updated lang string to explain all allowed statuses (we don't handle some e.g. cancelled)
2. Added some notes/caveats to help lang string
3. Updated tests to match

Testing
This is covered by new unit tests

matthewhilton self-assigned this

matthewhilton marked this pull request as ready for review

November 13, 2025 01:09

keevan reviewed

View reviewed changes

classes/booking_manager.php Outdated Show resolved Hide resolved

keevan reviewed

View reviewed changes

classes/booking_manager.php Show resolved Hide resolved

keevan reviewed

View reviewed changes

classes/form/upload_bookings_form.php Outdated Show resolved Hide resolved

keevan reviewed

View reviewed changes

classes/form/upload_bookings_form.php Show resolved Hide resolved

keevan reviewed

View reviewed changes

tests/upload_test.php Show resolved Hide resolved

keevan reviewed

View reviewed changes

tests/upload_test.php Outdated Show resolved Hide resolved

keevan reviewed

View reviewed changes

tests/upload_test.php Outdated Show resolved Hide resolved

keevan reviewed

View reviewed changes

tests/upload_test.php Outdated Show resolved Hide resolved

matthewhilton force-pushed the 269-upload-handle-headers branch from 386fe6e to 293f283 Compare

December 1, 2025 05:31

matthewhilton added 8 commits

December 15, 2025 15:14


          [#269] Handle optional headers better

cc4a47c


          [#270] Upload directly with attendance status

640ec2c


          [#270] Code standards fixups

524e56b


          [#270] Clarify wording around attendance upload edge case

dc5d95d


          [#270] Fix test case

8d88530


          [#270] Improve testing

9e3b1e5


          [#270] Moodle 4.3 compatibility

dd4a26a


          [#270] Fixup small issues

e54805c

matthewhilton force-pushed the 269-upload-handle-headers branch from 293f283 to e54805c Compare

December 15, 2025 05:15

Contributor

keevan commented Dec 18, 2025

Looks good to me. Merging.

keevan merged commit 090f87f into MOODLE_403_STABLE

19 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet