Skip to content

Conversation

@owenherbert-catalyst
Copy link
Contributor

This merge requests introduces a new idnumber column for the attendees table. This new column can be toggled on/off with a new configuration setting. This column will also abide by the Moodle userpolicies configuration. The attendees download file will include the new field when enabled.

image

What's been done?

  • Add new idnumber column to page and download file.
  • New attendeesshowidnumbers config setting.

Testing instructions:

  1. Install this plugin branch on a Moodle 4.5 site.
  2. Create an admin user and a student.
  3. Confirm new "Show id number in attendees table" plugin setting exists. Set it to true.
  4. Add idnumber to "Show user identity" Moodle setting. ({domain}/admin/settings.php?section=userpolicies)
  5. Create a test course.
  6. Add F2F to the test course.
  7. Enroll all users to the test course.
  8. Create a F2F session.
  9. Add all users to the F2F session.
  10. Confirm all users appear in the attendees table and the columns are populated with data. Also check downloaded file.
  11. Run unit tests with vendor/bin/phpunit --testsuite mod_facetoface_testsuite.

@owenherbert-catalyst owenherbert-catalyst changed the title Add new setting & functionality Add new idnumber column Dec 15, 2025
@owenherbert-catalyst owenherbert-catalyst changed the title Add new idnumber column Add idnumber to attendees table Dec 15, 2025
@owenherbert-catalyst owenherbert-catalyst marked this pull request as ready for review December 15, 2025 23:06
attendees.php Outdated
$table->head[] = get_string('username');
$table->align[] = 'left';
$table->size[] = '30%';
$table->size[] = '25%';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This size feels like it should respect which columns are active.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, now that we have a few columns this value should be calculated dynamically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've set the size to be auto so that width is calculated dynamically.

1 2 3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great this is looking much better

@Peterburnett Peterburnett merged commit f73ecd1 into MOODLE_403_STABLE Dec 18, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants