feat: theme style injection#79
Merged
matthewhilton merged 1 commit intostable-catalystfrom Jan 22, 2026
Merged
Conversation
|
I'm not a big fan of passing things by reference as I think it leads to accidental bugs later on, but given it already uses this pattern for Looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new hook to allow themes to inject css styling when the H5P editor opens.
There is an existing hook which is
hvp_alter_styles, however this hook injects the styling when a library is loaded, meaning styling won't be applied until a library is selected and the styling will be applied whenever a library is loaded. This new hook will inject the styling earlier and will only inject it for the H5P editor and not when viewing a H5P activity.