fix: change embedded H5P resize delay to 1ms#80
Merged
rhell4 merged 1 commit intostable-catalystfrom Feb 11, 2026
Merged
Conversation
keevan
approved these changes
Feb 11, 2026
keevan
left a comment
There was a problem hiding this comment.
Code wise I see no issue with the changes here. Ideally things that need to happen in a specific order aren't done with timeouts, but sometimes timeouts are the simplest approach.
Happy for this to land as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client noticed some embedded H5P activities were leaving extra white space on the page when it resizes. This was because the iframe height wasn't being adjusted. It seems like a delay of 0ms is too fast for some content types (book is fine but document tool isn't).
Solution: change the delay to 1ms
Testing: