New metric for 12 months rolling active users - Back fill function #180#184
Merged
jaypha merged 1 commit intoMOODLE_404_STABLEfrom Jul 18, 2025
Merged
Conversation
jaypha
reviewed
Jul 18, 2025
jaypha
reviewed
Jul 18, 2025
jaypha
reviewed
Jul 18, 2025
jaypha
reviewed
Jul 18, 2025
duyhuynhdev
force-pushed
the
new-metric-for-rolling-active-users-backfill
branch
from
c807d45 to
541a608
Compare
Contributor
|
What about $backwardperiod and $finishtime? $backwardperiod is an int, and $finishtime is a nullable int. You need to put in type hinting for these as well. |
duyhuynhdev
force-pushed
the
new-metric-for-rolling-active-users-backfill
branch
from
541a608 to
76e3970
Compare
duyhuynhdev
added a commit
that referenced
this pull request
Jul 21, 2025
… (#184) Co-authored-by: dustinhuynh <dustinhuynh@catalyst-au.net>
brendanheywood
pushed a commit
that referenced
this pull request
Jul 21, 2025
… (#184) Co-authored-by: dustinhuynh <dustinhuynh@catalyst-au.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New metric for 12 months rolling active users - Back fill function #180
Closes #180