-
Notifications
You must be signed in to change notification settings - Fork 78
Added Path Style Endpoint #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: MOODLE_404_STABLE
Are you sure you want to change the base?
Conversation
Used for alternative software endpoints like MinIo
|
@danmarsden If you believe this isn't necessary I can close the commit? |
|
I tend to leave the S3 checks to our AU devs to review unless it's a no-brainer. We use the swift end-points in the NZ team so I haven't looked at it that close.. @Peterburnett is this something you can take a look at? |
|
Personally I have to add the line of code to our Moodle Servers to add this path style endpoint so we can use Minio, because it doesn't work with the normal endpoints. Just thought others might want to use it as well |
Tchekda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only Min.io but most of the other s3-like systems
|
Can I close this merge? Has it been merged to the main? |
Frostist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏻
|
If this gets merged #483 can be closed as well. |
|
Nice to see others want this as well 🙌🏻 |
|
Is this going to be merged soon? |
Used for alternative software endpoints like MinIo.
I am wanting to add this setting to the stable branch. Which will add a tickbox to allow uses that use alternative S3 storage methods other than AWS to store there data.
With Min.io it can't use the AWS standard and uses the "path style endpoint" which the AWS S3 plugin integrates with.