Merged
Conversation
Refactor ImagingSpace coordinates: - [ ] disambiguate imaging origin coodinates from anatomical origin coordinates - [ ] use/implement CoordinateSystem and Position objects
…mock_MicroscopyResponseSeries
…o/ndx-microscopy into NWBEP0004_reviews_2
alessandratrapani
changed the base branch from
NWBEP0004_reviews
to
NWBEP0004_reviews_2
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor ImagingSpace coordinates:
The ImagingSpace class should only store information about the ImagingSpace:
-> anatomical target
-> pixel dimensions
-> image dimension
-> illumination pattern
The localization with respect to a specific coordinate system, either stereotactic or common coordinate framework, is delegated to the ndx-anatomical-localization