Skip to content

Fix unused stub_test parameter in OpenEphysBinaryRecordingInterface#1665

Closed
Copilot wants to merge 2 commits intodeprecate_postional_only_on_nwbfilefrom
copilot/sub-pr-1663
Closed

Fix unused stub_test parameter in OpenEphysBinaryRecordingInterface#1665
Copilot wants to merge 2 commits intodeprecate_postional_only_on_nwbfilefrom
copilot/sub-pr-1663

Conversation

Copy link
Contributor

Copilot AI commented Feb 13, 2026

The stub_test parameter was being extracted from deprecated positional arguments but never passed to the parent class, making it effectively unused.

Changes

  • Added stub_test to super().__init__() call in OpenEphysBinaryRecordingInterface.__init__()

This ensures stub_test flows through to _initialize_extractor() where it's popped from kwargs before extractor instantiation, matching the intended behavior for test stubbing.

super().__init__(
    folder_path=folder_path,
    stream_name=stream_name,
    block_index=block_index,
    stub_test=stub_test,  # Now properly threaded through
    verbose=verbose,
    es_key=es_key,
)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: h-mayorquin <6429509+h-mayorquin@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on deprecating positional conversion options Fix unused stub_test parameter in OpenEphysBinaryRecordingInterface Feb 13, 2026
Copilot AI requested a review from h-mayorquin February 13, 2026 18:10
@h-mayorquin h-mayorquin deleted the copilot/sub-pr-1663 branch February 13, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants