Fix unused stub_test parameter in OpenEphysBinaryRecordingInterface#1665
Closed
Copilot wants to merge 2 commits intodeprecate_postional_only_on_nwbfilefrom
Closed
Fix unused stub_test parameter in OpenEphysBinaryRecordingInterface#1665Copilot wants to merge 2 commits intodeprecate_postional_only_on_nwbfilefrom
Copilot wants to merge 2 commits intodeprecate_postional_only_on_nwbfilefrom
Conversation
Co-authored-by: h-mayorquin <6429509+h-mayorquin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on deprecating positional conversion options
Fix unused stub_test parameter in OpenEphysBinaryRecordingInterface
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
stub_testparameter was being extracted from deprecated positional arguments but never passed to the parent class, making it effectively unused.Changes
stub_testtosuper().__init__()call inOpenEphysBinaryRecordingInterface.__init__()This ensures
stub_testflows through to_initialize_extractor()where it's popped from kwargs before extractor instantiation, matching the intended behavior for test stubbing.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.