Skip to content

Remove deprecated stub_frames parameter from ophys interfaces#1676

Merged
h-mayorquin merged 11 commits intomainfrom
remove-stub-frames-deprecation
Mar 9, 2026
Merged

Remove deprecated stub_frames parameter from ophys interfaces#1676
h-mayorquin merged 11 commits intomainfrom
remove-stub-frames-deprecation

Conversation

@h-mayorquin
Copy link
Collaborator

Removed the stub_frames parameter (deprecated since February 2026) from all ophys interfaces. Users should use stub_samples instead.

Affected classes: BaseImagingExtractorInterface, BaseSegmentationExtractorInterface, BrukerTiffMultiPlaneConverter, BrukerTiffSinglePlaneConverter, MiniscopeConverter, Suite2pSegmentationInterface, MinianSegmentationInterface, _MiniscopeMultiRecordingInterface

h-mayorquin and others added 5 commits February 23, 2026 21:41
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Contributor

@alessandratrapani alessandratrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-mayorquin h-mayorquin enabled auto-merge (squash) March 9, 2026 15:20
@h-mayorquin h-mayorquin merged commit 3083011 into main Mar 9, 2026
24 checks passed
@h-mayorquin h-mayorquin deleted the remove-stub-frames-deprecation branch March 9, 2026 16:43
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 48.07692% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.76%. Comparing base (b630a43) to head (48e1c1b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/neuroconv/tools/hdmf.py 23.80% 32 Missing ⚠️
...oconv/datainterfaces/behavior/video/video_utils.py 45.45% 12 Missing ⚠️
...roiextractors/imagingextractordatachunkiterator.py 80.95% 4 Missing ⚠️
...erface/spikeinterfacerecordingdatachunkiterator.py 66.66% 4 Missing ⚠️
...datainterfaces/ophys/minian/miniandatainterface.py 0.00% 1 Missing ⚠️
...tainterfaces/ophys/suite2p/suite2pdatainterface.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1676      +/-   ##
==========================================
- Coverage   81.08%   80.76%   -0.32%     
==========================================
  Files         160      160              
  Lines       12574    12635      +61     
==========================================
+ Hits        10195    10205      +10     
- Misses       2379     2430      +51     
Flag Coverage Δ
unittests 80.76% <48.07%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ainterfaces/ophys/baseimagingextractorinterface.py 80.00% <100.00%> (+2.98%) ⬆️
...rfaces/ophys/basesegmentationextractorinterface.py 80.00% <100.00%> (+0.68%) ⬆️
...interfaces/ophys/brukertiff/brukertiffconverter.py 94.44% <ø> (+6.20%) ⬆️
...tainterfaces/ophys/miniscope/miniscopeconverter.py 95.00% <100.00%> (-0.24%) ⬇️
...s/ophys/miniscope/miniscopeimagingdatainterface.py 77.91% <ø> (-0.14%) ⬇️
...datainterfaces/ophys/minian/miniandatainterface.py 64.28% <0.00%> (ø)
...tainterfaces/ophys/suite2p/suite2pdatainterface.py 71.73% <0.00%> (ø)
...roiextractors/imagingextractordatachunkiterator.py 94.20% <80.95%> (-5.80%) ⬇️
...erface/spikeinterfacerecordingdatachunkiterator.py 88.88% <66.66%> (-11.12%) ⬇️
...oconv/datainterfaces/behavior/video/video_utils.py 89.02% <45.45%> (-6.84%) ⬇️
... and 1 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants