Remove February 2026 deprecated parameters#1678
Merged
h-mayorquin merged 4 commits intomainfrom Mar 3, 2026
Merged
Conversation
Remove staging from _dandi.py, container_name from ImageInterface and DeepLabCutInterface, and time_series_name from spikeinterface. Also clean up empty positional argument deprecation blocks where container_name was the only tracked parameter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pauladkisson
reviewed
Mar 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1678 +/- ##
==========================================
+ Coverage 80.23% 80.41% +0.18%
==========================================
Files 160 160
Lines 12663 12632 -31
==========================================
- Hits 10160 10158 -2
+ Misses 2503 2474 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove February 2026 deprecated parameters
Removes four deprecated parameters that were scheduled for removal on or before February 2026:
stagingparameter fromautomatic_dandi_uploadin_dandi.py(deprecated October 2024, usesandboxinstead)container_nameparameter fromImageInterface.add_to_nwbfile(deprecated February 2026, usemetadata_keyin__init__instead)container_nameparameter fromDeepLabCutInterface.add_to_nwbfile(deprecated February 2026, usepose_estimation_metadata_keyin__init__instead)time_series_nameparameter fromadd_recording_as_time_series_to_nwbfile(deprecated February 2026, usemetadata_keyinstead)Also cleans up empty positional argument deprecation blocks in
ImageInterface.add_to_nwbfileandDeepLabCutInterface.add_to_nwbfilewherecontainer_namewas the only tracked parameter (replaced*argswith*or removed entirely). TheImageInterface.__init__positional argument deprecation is also replaced with keyword-only enforcement using*.