Remove iterator_type v1 and rate in trace metadata deprecations#1679
Merged
h-mayorquin merged 6 commits intomainfrom Mar 9, 2026
Merged
Remove iterator_type v1 and rate in trace metadata deprecations#1679h-mayorquin merged 6 commits intomainfrom
h-mayorquin merged 6 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1679 +/- ##
==========================================
- Coverage 81.08% 80.75% -0.33%
==========================================
Files 160 160
Lines 12574 12622 +48
==========================================
- Hits 10195 10193 -2
- Misses 2379 2429 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove March 2026 deprecated features in roiextractors
iterator_type='v1'support from_imaging_frames_to_hdmf_iterator.ratein trace metadata for fluorescence traces. The rate is now always calculated automatically from the segmentation extractor's timestamps or sampling frequency.DataChunkIteratorimports from both source and test files.test_deprecated_v1_iterator_two_photontest.