Skip to content

Complete TestAddImaging tests for the dict-based metadata pipeline#1685

Merged
h-mayorquin merged 18 commits intomainfrom
complete_add_imaging_tests
Mar 9, 2026
Merged

Complete TestAddImaging tests for the dict-based metadata pipeline#1685
h-mayorquin merged 18 commits intomainfrom
complete_add_imaging_tests

Conversation

@h-mayorquin
Copy link
Collaborator

Completes the tests that were missing from #1677 to keep that diff focused on the implementation. The remaining tests are added here in the new pytest format so we can drop TestAddPhotonSeries entirely once we drop support for the list-based metadata format (September 2026).

@h-mayorquin h-mayorquin changed the base branch from main to new_add_device_function March 4, 2026 21:17
Base automatically changed from new_add_device_function to main March 4, 2026 22:41
@h-mayorquin h-mayorquin marked this pull request as ready for review March 5, 2026 06:36
@h-mayorquin h-mayorquin requested a review from pauladkisson March 5, 2026 06:40
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@h-mayorquin h-mayorquin enabled auto-merge (squash) March 9, 2026 07:00
@h-mayorquin h-mayorquin merged commit e430a67 into main Mar 9, 2026
24 checks passed
@h-mayorquin h-mayorquin deleted the complete_add_imaging_tests branch March 9, 2026 07:40
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.01%. Comparing base (b630a43) to head (0ce7c14).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1685      +/-   ##
==========================================
- Coverage   81.08%   81.01%   -0.07%     
==========================================
  Files         160      160              
  Lines       12574    12589      +15     
==========================================
+ Hits        10195    10199       +4     
- Misses       2379     2390      +11     
Flag Coverage Δ
unittests 81.01% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nv/tools/nwb_helpers/_metadata_and_file_helpers.py 91.81% <ø> (ø)
src/neuroconv/tools/roiextractors/roiextractors.py 75.90% <ø> (-1.14%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants