Skip to content

Make add_segmentation kwarg only#1687

Merged
h-mayorquin merged 1 commit intomainfrom
args_kwargs_segmentation
Mar 9, 2026
Merged

Make add_segmentation kwarg only#1687
h-mayorquin merged 1 commit intomainfrom
args_kwargs_segmentation

Conversation

@h-mayorquin
Copy link
Collaborator

As in the name.

@h-mayorquin h-mayorquin self-assigned this Mar 5, 2026
@h-mayorquin h-mayorquin requested a review from pauladkisson March 5, 2026 06:49
@h-mayorquin h-mayorquin marked this pull request as ready for review March 5, 2026 06:49
@h-mayorquin h-mayorquin merged commit ec548c2 into main Mar 9, 2026
31 of 33 checks passed
@h-mayorquin h-mayorquin deleted the args_kwargs_segmentation branch March 9, 2026 07:00
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.99%. Comparing base (b630a43) to head (6c893ae).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/neuroconv/tools/roiextractors/roiextractors.py 6.66% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
- Coverage   81.08%   80.99%   -0.09%     
==========================================
  Files         160      160              
  Lines       12574    12589      +15     
==========================================
+ Hits        10195    10196       +1     
- Misses       2379     2393      +14     
Flag Coverage Δ
unittests 80.99% <6.66%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/neuroconv/tools/roiextractors/roiextractors.py 75.45% <6.66%> (-1.59%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants