Skip to content

Remove scan image deprecations#1688

Merged
h-mayorquin merged 3 commits intomainfrom
scan_image_deprecations
Mar 9, 2026
Merged

Remove scan image deprecations#1688
h-mayorquin merged 3 commits intomainfrom
scan_image_deprecations

Conversation

@h-mayorquin
Copy link
Collaborator

The time has come

@h-mayorquin h-mayorquin self-assigned this Mar 9, 2026
@h-mayorquin h-mayorquin marked this pull request as ready for review March 9, 2026 19:20
@h-mayorquin h-mayorquin requested a review from pauladkisson March 9, 2026 21:23
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@h-mayorquin h-mayorquin enabled auto-merge (squash) March 9, 2026 22:09
@h-mayorquin h-mayorquin merged commit 956eadb into main Mar 9, 2026
24 checks passed
@h-mayorquin h-mayorquin deleted the scan_image_deprecations branch March 9, 2026 22:38
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.86%. Comparing base (b630a43) to head (748fb38).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
- Coverage   81.08%   80.86%   -0.22%     
==========================================
  Files         160      160              
  Lines       12574    12585      +11     
==========================================
- Hits        10195    10177      -18     
- Misses       2379     2408      +29     
Flag Coverage Δ
unittests 80.86% <100.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...aces/ophys/scanimage/scanimageimaginginterfaces.py 79.60% <100.00%> (+0.65%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants