Add websocket and rpc request gen to txgen #2394
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipglazman
force-pushed
the
pg/ws-stress
branch
from
77c5128 to
82bf488
Compare
philipglazman
force-pushed
the
pg/ws-stress
branch
from
82bf488 to
aad4a00
Compare
JoeHowarth
reviewed
Oct 13, 2025
|
|
||
| pub async fn run(&self) { | ||
| // number of concurrent websocket connections | ||
| let num_connections: usize = 4; |
There was a problem hiding this comment.
add this as a configurable struct field or run fn arg?
| for _ in 0..num_connections { | ||
| let ws_url = self.ws_url.clone(); | ||
| let http_client = self.rpc_client.clone(); | ||
| tasks.push(tokio::spawn(async move { |
There was a problem hiding this comment.
Please split this into a separate fn (and sub-fns since this block is quite long.
| for _ in 0..num_connections { | ||
| let ws_url = self.ws_url.clone(); | ||
| let http_client = self.rpc_client.clone(); | ||
| tasks.push(tokio::spawn(async move { |
There was a problem hiding this comment.
These tasks need to be cancellable. See other workers for examples
| .into_iter()) | ||
| let mut tasks = Vec::new(); | ||
|
|
||
| if traffic_gen.spam_rpc { |
There was a problem hiding this comment.
Not sure, but this feels like it would be better as a WorkloadGroup level arg instead of TrafficGen. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.