Skip to content

Conversation

@philipglazman
Copy link
Contributor

Operators can set a higher provider gas limit for eth_call and eth_estimateGas and meter usage themselves.

@Copilot Copilot AI review requested due to automatic review settings September 30, 2025 20:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes gas limit restrictions that previously capped provider gas limits to the block gas limit for eth_call and eth_estimateGas operations. This allows operators to configure higher gas limits for these operations and manage gas usage independently.

  • Removes minimum constraint between provider gas limit and block gas limit in gas estimation
  • Removes minimum constraint between provider gas limit and block gas limit in eth_call preparation
  • Removes explicit gas limit validation that rejected transactions with gas limits exceeding the block gas limit

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
monad-rpc/src/handlers/eth/gas.rs Removes provider gas limit constraint in gas estimation
monad-rpc/src/handlers/eth/call.rs Removes provider gas limit constraint in call preparation
monad-ethcall/src/lib.rs Removes gas limit validation that enforced block gas limit ceiling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

eerkaijun
eerkaijun previously approved these changes Oct 1, 2025
omegablitz
omegablitz previously approved these changes Oct 23, 2025
Copy link
Contributor

@eerkaijun eerkaijun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in https://github.com/category-labs/monad-bft/blob/pg/gas-provider-limit/monad-rpc/src/handlers/eth/call.rs#L487 we are still upper bounding by block gas limit, will need to remove that upper bound too i think

Operators can set a higher provider gas limit for eth_call and eth_estimateGas and meter usage themselves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants