Skip to content

Conversation

@xinyuan-dev
Copy link
Contributor

This PR implements the rounding up chunk assignment algorithm proposed in #2215.

@Copilot Copilot AI review requested due to automatic review settings October 23, 2025 13:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a rounding-up chunk assignment algorithm for RaptorCast by introducing the StakeBasedWithRC assigner for validator-based RaptorCast. The changes transition from the Partitioned assigner to StakeBasedWithRC for validator RaptorCast while maintaining backward compatibility for full-node RaptorCast.

Key changes:

  • Switches validator RaptorCast to use StakeBasedWithRC assigner instead of Partitioned
  • Adds comprehensive tests comparing chunk assignment properties between the two assigners
  • Updates test infrastructure with more realistic stake distribution modeling

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
monad-raptorcast/src/packet/builder.rs Updates BuildTarget::Raptorcast to use StakeBasedWithRC assigner
monad-raptorcast/src/packet/assigner.rs Marks Partitioned::from_validator_set as unused in production, removes unused annotation from StakeBasedWithRC, adds property tests and realistic stake distribution
monad-raptorcast/Cargo.toml Adds rand_distr dependency for stake distribution modeling
.github/workflows/test-command.yml Pins cargo-binstall to v1.15.7
.github/workflows/rust.yml Pins cargo-binstall to v1.15.7

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@xinyuan-dev xinyuan-dev force-pushed the xinyuan/rounding-chunk branch 3 times, most recently from 96fe396 to ec98c15 Compare October 23, 2025 14:25
@xinyuan-dev xinyuan-dev requested a review from tklenze October 23, 2025 16:00
@omegablitz omegablitz force-pushed the xinyuan/rounding-chunk branch from ec98c15 to 5596d72 Compare October 24, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant