feat: add scrollbar styling #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ninetailedtori <[email protected]>
Contributor
Author
|
Urgh, I'm not sure though. Setting scrollbar track to surface1 or surface2 would be best for a user using 100% track opacity. But setting it to surface2 with transparency personally was a little too...invisible. Willing to take advice on this. |
After careful consideration, using this works best for both scrollbar track opacity AND transparency users. Signed-off-by: ninetailedtori <[email protected]>
Contributor
Author
|
After careful consideration, using surface1 on the track works best for both scrollbar track opacity AND transparency users. As such, this will be the easiest change. We could choose different colours dependent on transparency but...given it's a variable opacity from 0.0 to 1.0, you have a lot of different opacities to test and decide. |
Signed-off-by: ninetailedtori <[email protected]>
Signed-off-by: ninetailedtori <[email protected]>
sgoudham
reviewed
Jan 4, 2026
Signed-off-by: Toria <[email protected]>
sgoudham
approved these changes
Jan 16, 2026
Contributor
sgoudham
left a comment
sgoudham
left a comment
There was a problem hiding this comment.
Sorry for the wait, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used rosewater and overlay1 (latter mostly for visibility, former as we use accent on scrollbar quite often). Don't think we need to add opacity, that should be done outside of themes and inside of the main user's config.