Skip to content

fix: lua highlighting to match styleguide#22

Merged
jack-mil merged 3 commits intocatppuccin:mainfrom
jack-mil:lua-syntax
Feb 24, 2025
Merged

fix: lua highlighting to match styleguide#22
jack-mil merged 3 commits intocatppuccin:mainfrom
jack-mil:lua-syntax

Conversation

@jack-mil
Copy link
Member

Again, the Npp language syntax lexer is very basic, so this results in a much less colorful theme then VSCode (esp. in doc-comments)

Before After
lua-before lua-after
Idea for doc-comments (?) lua-after-docs
Another example
VS Code for reference

To be merged after #14

Relates to #17

jack-mil and others added 2 commits February 17, 2025 17:15
Again, the Npp language syntax lexer is very basic, so this results in a
much less colorful theme then VSCode (esp. in doc-comments)

To be merged *after* #14

Relates to #17
@jack-mil jack-mil changed the title feat: update lua highlighting to match styleguide fix: lua highlighting to match styleguide Feb 18, 2025
@sgoudham
Copy link
Contributor

I think I'd prefer doc comments to be overlay even if it looks more "bland", the yellow is quite off-putting to me.

@uncenter
Copy link
Member

I think I'd prefer doc comments to be overlay even if it looks more "bland", the yellow is quite off-putting to me.

(This is how we do it in all the other syntax highlighting ports fwiw.)


Can we make booleans peach instead of mauve here?

@jack-mil
Copy link
Member Author

Can we make booleans peach instead of mauve here?

Not really, all builtin keywords are hardcoded for this one, and it includes "true" "false" and "nill" along with "function" "return" "local" etc....
So unless you are ok with all of those being peach too...

@uncenter
Copy link
Member

It's fine then, keywords being mauve is more important than bools being peach. 👍

Also unfortunately operators [+=-*/], but it is more
consistent with choices for other language PRs
@jack-mil
Copy link
Member Author

Sorry to wake this conversation up again, but I realized when looking at this again that to be consistent with choices in the other PRs, I think braces and parenthesis should be overlay2. In Npp this is the "OPERATOR" group for Lua, so unfortunately that means [+-*/=] won't be sky. This is the same compromise for Python in #31.

image
image

@jack-mil jack-mil merged commit 3b92ae8 into catppuccin:main Feb 24, 2025
1 check passed
@jack-mil jack-mil deleted the lua-syntax branch February 24, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants