Take screenshots and insert them in the json file

[marcelovani]

Issue #10

What it does

• Introduces a new configuration to specify the Behat extension that provides screenshots
• The container will first find services with tag id screenshot.service and compare the class vs configuration
• Updated readme
• Keeps track of files for each step
• Sends the files to json output

Testing
Add these entries on composer.json

  "repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/marcelovani/behat-screenshot.git"
    },
    {
      "type": "vcs",
      "url": "https://github.com/marcelovani/behat-cucumber-formatter.git"
    }
  ],

then

  "require-dev": {
    "cawolf/behat-cucumber-json-formatter": "dev-10-screenshots-support",
    "bex/behat-screenshot": "dev-61-event-dispatcher-breaking-formatter"
  }

Screenshot

[marcelovani]

New approach, description updated

[cawolf]

Thank you for this PR! I left some small notes for you to review.

[cawolf]

This line should be a line lower. The next line ("If this option is set to true..." belongs to the resultFilePerSuite option, not to the screenshotExtension.

[marcelovani]

Fixed

[cawolf]

I did not check the referenced package too deeply, but I imagine that this service tag is introduced by the other package?

[marcelovani]

Yes, I tried to come up with a generic solution
For reference https://github.com/elvetemedve/behat-screenshot/pull/62/files#diff-367a0438232ae30182922c4e9618bd66be531f661c4e57d09b710749010b7fb9R23

[cawolf]

This code leads to the last of all matching services being selected as imageUploaderService, not the first. I assume this is intended behaviour?
If so, a short comment would be nice.

[marcelovani]

That was not intentional. I added a break.
If you think we should change this behaviour, please let me know.