Save needlessly collecting list in InternalMappedSignificantTerms (elastic#112502)

original-brownbear · cbuescher · commit 7787ee0f8b8a · 2024-09-04T21:21:08.000+02:00
No need to allocate a list+stream to do an unsafe(ish) cast.
diff --git a/server/src/main/java/org/elasticsearch/search/aggregations/bucket/terms/InternalMappedSignificantTerms.java b/server/src/main/java/org/elasticsearch/search/aggregations/bucket/terms/InternalMappedSignificantTerms.java
@@ -71,8 +71,9 @@ protected final void writeTermTypeInfoTo(StreamOutput out) throws IOException {
     }
 
     @Override
+    @SuppressWarnings({ "rawtypes", "unchecked" })
     public Iterator<SignificantTerms.Bucket> iterator() {
-        return buckets.stream().map(bucket -> (SignificantTerms.Bucket) bucket).toList().iterator();
+        return (Iterator) buckets.iterator();
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -71,8 +71,9 @@ protected final void writeTermTypeInfoTo(StreamOutput out) throws IOException {`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`@Override`
	`74`	`+ @SuppressWarnings({ "rawtypes", "unchecked" })`
`74`	`75`	`public Iterator<SignificantTerms.Bucket> iterator() {`
`75`		`- return buckets.stream().map(bucket -> (SignificantTerms.Bucket) bucket).toList().iterator();`
	`76`	`+ return (Iterator) buckets.iterator();`
`76`	`77`	`}`
`77`	`78`
`78`	`79`	`@Override`