Skip to content

refactor: Theme & ThemeOptions #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fhammerschmidt merged 2 commits into from
Mar 10, 2025
Merged

refactor: Theme & ThemeOptions #232

fhammerschmidt merged 2 commits into from
Mar 10, 2025

Conversation

@illusionalsagacity
Copy link
Contributor

@illusionalsagacity illusionalsagacity commented Feb 28, 2025 •
edited
Loading

  • Makes the type naming more consistent between Theme and ThemeOptions
  • Re-order types to be defined in the same order in each module
  • Fixes the breakpoints function types on the theme
  • Removes the now unnecessary runtime overhead of ThemeHelpers.addBreakpoint
  • Add ThemeHelpers.addBreakpointDown function
  • Add ExampleTheme.res file to the repo

resolves #219

@fhammerschmidt
Copy link
Member

fhammerschmidt commented Mar 4, 2025

What's the state of this?

@illusionalsagacity
Copy link
Contributor Author

illusionalsagacity commented Mar 4, 2025

What's the state of this?

Hey, I want to do another once-over to make sure I made the two things consistent and to put an example file in as well to check against the typescript types.

@illusionalsagacity illusionalsagacity changed the title refactor(WIP): Theme & ThemeOptions refactor: Theme & ThemeOptions Mar 5, 2025
@illusionalsagacity illusionalsagacity marked this pull request as ready for review March 5, 2025 06:21
@illusionalsagacity
refactor: Theme & ThemeOptions
c748d4b 
- Makes the naming more consistent between the two (needs another check)
- Re-order types to be defined in the same order in each module
- Fixes the breakpoints function types on the theme
- Removes the now unnecessary runtime overhead of ThemeHelpers.addBreakpoint
- Add ThemeHelpers.addBreakpointDown function
- Add ExampleTheme.res file to the repo
fhammerschmidt
fhammerschmidt approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work.

@fhammerschmidt fhammerschmidt merged commit 1f6c080 into cca-io:master Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhammerschmidt fhammerschmidt fhammerschmidt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Theme type is missing the shadows and typography properties

2 participants

@illusionalsagacity @fhammerschmidt