Add FireSim changes to the standard 2017 branch#14
Draft
Conversation
few lines that returned non-zero exit codes even when they worked.
few lines that returned non-zero exit codes even when they worked.
format. Currently doesn't include HW counters in the CSV.
More metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@davidbiancolin added some handy scripts to Speckle2017 and made a few tweaks for FireSim. Should we try to merge these into the regular 2017 branch?
Major Changes:
metric collection to let users provide an additional measurement script.
Opinions?