Added testnet endpoint for the Futures websockets #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@shalev-david thanks for your contribution! |
Collaborator
|
@shalev-david can you please check the lint? |
Contributor
Author
|
the other lint errors are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had an issue trying to work with the future's websockets on the testate,
after a quick Look at the code I saw that the endpoints are hardcoded with no testnets options so I've added them. \
at
src/futures/websockets.rsthere's theFuturesMarketenumI've added to the enum these values with these endpoints:
USDM_Testnet-wss://fstream.binancefuture.comCOINM_Testnet-wss://dstream.binancefuture.comVanilla_Testnet-wss://vstream.binancefuture.com