Skip to content

Commit acaf7b2

Browse files
committed
* Fixing custom_crf not being found (thanks to Norbert)
1 parent c284c3a commit acaf7b2

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

CHANGES

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## Version 5.11.1
4+
5+
* Fixing custom_crf not being found (thanks to Norbert)
6+
37
## Version 5.11.0
48

59
* Adding parallel encoding options for rigaya hardware encoders (thanks to Hexenhammer)

fastflix/encoders/common/setting_panel.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ def _add_modes(
375375
self.widgets.bitrate.addItems(recommended_bitrates)
376376
self.widgets.bitrate_passes = QtWidgets.QComboBox()
377377
self.widgets.bitrate_passes.addItems(["1", "2"])
378-
self.widgets.bitrate_passes.currentIndexChanged.connect(lambda: self.mode_update())
378+
379379
config_opt = self.app.fastflix.config.encoder_opt(self.profile_name, "bitrate")
380380
custom_bitrate = False
381381
try:
@@ -387,7 +387,6 @@ def _add_modes(
387387
self.widgets.bitrate.setCurrentText("Custom")
388388
else:
389389
self.widgets.bitrate.setCurrentIndex(default_bitrate_index)
390-
self.widgets.bitrate.currentIndexChanged.connect(lambda: self.mode_update())
391390
self.widgets.custom_bitrate = QtWidgets.QLineEdit("3000" if not custom_bitrate else config_opt)
392391
self.widgets.custom_bitrate.setValidator(QtGui.QDoubleValidator())
393392
self.widgets.custom_bitrate.setFixedWidth(100)
@@ -429,7 +428,6 @@ def _add_modes(
429428
if default_qp_index is not None:
430429
self.widgets[qp_name].setCurrentIndex(default_qp_index)
431430

432-
self.widgets[qp_name].currentIndexChanged.connect(lambda: self.mode_update())
433431
if not disable_custom_qp:
434432
self.widgets[f"custom_{qp_name}"] = QtWidgets.QLineEdit("30" if not custom_qp else str(qp_value))
435433
self.widgets[f"custom_{qp_name}"].setFixedWidth(100)
@@ -443,6 +441,9 @@ def _add_modes(
443441
self.bitrate_radio.setChecked(True)
444442
if not disable_bitrate:
445443
qp_box_layout.addWidget(self.qp_radio)
444+
self.widgets.bitrate_passes.currentIndexChanged.connect(lambda: self.mode_update())
445+
self.widgets.bitrate.currentIndexChanged.connect(lambda: self.mode_update())
446+
self.widgets[qp_name].currentIndexChanged.connect(lambda: self.mode_update())
446447
qp_box_layout.addWidget(self.widgets[qp_name], 1)
447448
qp_box_layout.addStretch(1)
448449
qp_box_layout.addStretch(1)

fastflix/encoders/hevc_x265/settings_panel.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -566,8 +566,7 @@ def init_modes(self):
566566
return self._add_modes(recommended_bitrates, recommended_crfs, qp_name="crf", show_bitrate_passes=True)
567567

568568
def mode_update(self):
569-
if "custom_crf" in self.widgets:
570-
self.widgets.custom_crf.setDisabled(self.widgets.crf.currentText() != "Custom")
569+
self.widgets.custom_crf.setDisabled(self.widgets.crf.currentText() != "Custom")
571570
self.widgets.custom_bitrate.setDisabled(self.widgets.bitrate.currentText() != "Custom")
572571
self.main.build_commands()
573572

fastflix/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
#!/usr/bin/env python
22
# -*- coding: utf-8 -*-
3-
__version__ = "5.11.0"
3+
__version__ = "5.11.1"
44
__author__ = "Chris Griffith"

0 commit comments

Comments
 (0)