Merged
Conversation
cdgriffith
approved these changes
Nov 25, 2025
Owner
|
Thank you for the fixes! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This is a very nice program. Below are 2 small fixes.
I fixed the niceness values on POSIX. They were reversed originally.
I removed the REALTIME priority from the UI on Windows.
~Windows docs
This priority also requires
SeIncreaseBasePriorityPrivilegewhich users typically don't have. ~docsSidenote: Negative niceness requires elevated privileges on POSIX so these options remain non-functional.