chore: migrate from AwsCdkConstructLibrary to CdklabsConstructLibrary#2678
Merged
aemada-aws merged 6 commits intokubectl-v20/mainfrom Feb 20, 2026
Merged
Conversation
Migrate to CdklabsConstructLibrary from cdklabs-projen-project-types for cdklabs defaults and trusted publishing. Changes: - Switch to CdklabsConstructLibrary for cdklabs defaults - Enables trusted publishing for npm, PyPI, and NuGet by default (removes NPM_TOKEN, TWINE_USERNAME/TWINE_PASSWORD, NUGET_API_KEY) Additional options to preserve original behavior: - private: false - CdklabsConstructLibrary defaults to private: true, but this is a public package - setNodeEngineVersion: false - Prevent adding engines.node to package.json - npmAccess: javascript.NpmAccess.PUBLIC - Prevent adding publishConfig to package.json - trustedPublishing: false for NuGet - Keep using NUGET_API_KEY Similar to #2671
aemada-aws
force-pushed
the
migrate-cdklabs-construct-library-v20
branch
from
aef65f7 to
0c253a9
Compare
CdklabsConstructLibrary adds rosetta:extract to post-compile by default, but this package removes aws-cdk-lib and constructs from peer deps (they're not part of the public API). Without peer deps in the jsii assembly, rosetta can't resolve types for README code examples. The original AwsCdkConstructLibrary config did not run rosetta, so remove the rosetta:extract step to match the previous behavior.
leonmk-aws
requested changes
Feb 20, 2026
package.json
Outdated
| }, | ||
| "types": "lib/index.d.ts", | ||
| "stability": "stable", | ||
| "stability": "experimental", |
There was a problem hiding this comment.
Shouldn't stability remain stable ?
| publishToNuget: { | ||
| dotNetNamespace: `Amazon.CDK.Asset.KubectlV${SPEC_VERSION}`, | ||
| packageId: `Amazon.CDK.Asset.KubectlV${SPEC_VERSION}`, | ||
| trustedPublishing: false, |
There was a problem hiding this comment.
Why are we disabling trustedPublishing for nuget ?
Contributor
Author
There was a problem hiding this comment.
Amazon. prefix is reserved by awsdotnet
Update package stability from experimental to stable in projen configuration.
leonmk-aws
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to
CdklabsConstructLibraryfromcdklabs-projen-project-typesfor cdklabs defaults and trusted publishing.Changes
CdklabsConstructLibraryfor cdklabs defaultsAdditional options to preserve original behavior
private: false- CdklabsConstructLibrary defaults to private: true, but this is a public packagesetNodeEngineVersion: false- Prevent adding engines.node to package.jsonnpmAccess: javascript.NpmAccess.PUBLIC- Prevent adding publishConfig to package.jsontrustedPublishing: falsefor NuGet - Keep using NUGET_API_KEYSimilar to #2671