Skip to content

chore: remove Corepack usage from Dockerfiles and add CI build#198

Closed
Mattral wants to merge 2 commits intocdklabs:mainfrom
Mattral:fix/remove-corepack-ci
Closed

chore: remove Corepack usage from Dockerfiles and add CI build#198
Mattral wants to merge 2 commits intocdklabs:mainfrom
Mattral:fix/remove-corepack-ci

Conversation

@Mattral
Copy link

@Mattral Mattral commented Feb 4, 2026

Replaces Corepack installs with direct pnpm installs in Dockerfiles and adds a GitHub Actions workflow to build the affected images as a smoke test.

related issue


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mergify
Copy link

mergify bot commented Feb 4, 2026

❌ The current Mergify configuration is invalid

Details
  • Extra inputs are not permitted @ root → pull_request_rules → item 0 → actions → merge → strict
  • Extra inputs are not permitted @ root → pull_request_rules → item 0 → actions → merge → commit_message → title+body

@bestickley
Copy link
Contributor

Thanks for your contribution @Mattral! I see you're assuming pnpm, what if user is using npm or yarn as package manager?

@Mattral
Copy link
Author

Mattral commented Feb 5, 2026

Thanks for your contribution @Mattral! I see you're assuming pnpm, what if user is using npm or yarn as package manager?

Thank you for the feedback! You’re right, the current changes assume pnpm as the package manager. To make this more flexible, I’ll update the Dockerfiles and CI scripts to detect and use the user’s preferred package manager (npm, yarn, or pnpm). I’ll add logic to check for a lockfile (package-lock.json, yarn.lock, or pnpm-lock.yaml) and use the corresponding tool. I’ll also update the documentation to clarify this behavior.

@mergify
Copy link

mergify bot commented Feb 5, 2026

❌ The current Mergify configuration is invalid

Details
  • Extra inputs are not permitted @ root → pull_request_rules → item 0 → actions → merge → strict
  • Extra inputs are not permitted @ root → pull_request_rules → item 0 → actions → merge → commit_message → title+body

@Mattral
Copy link
Author

Mattral commented Feb 5, 2026

This update adds support for all major Node.js package managers (npm, yarn, pnpm) in Dockerfiles and CI workflows. The build system now automatically detects the correct package manager based on the presence of a lockfile (yarn.lock, package-lock.json, or pnpm-lock.yaml) and uses the appropriate install/run commands. Documentation has been updated to explain the new detection logic.

Copy link
Author

@Mattral Mattral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask for a review on what could be improved?

@bestickley
Copy link
Contributor

Hey @Mattral, I should have mentioned this initially, but I think #187 removes the need for this. Do you agree?

@Mattral
Copy link
Author

Mattral commented Feb 12, 2026

Hey @Mattral, I should have mentioned this initially, but I think #187 removes the need for this. Do you agree?

Oh I can see it. Thank you for following up.

@Mattral Mattral closed this Feb 12, 2026
@bestickley
Copy link
Contributor

You're welcome! Still really appreciate you pushing cdk-nextjs forward :) I'll close the related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants