chore: remove Corepack usage from Dockerfiles and add CI build#198
chore: remove Corepack usage from Dockerfiles and add CI build#198Mattral wants to merge 2 commits intocdklabs:mainfrom
Conversation
❌ The current Mergify configuration is invalidDetails
|
|
Thanks for your contribution @Mattral! I see you're assuming pnpm, what if user is using npm or yarn as package manager? |
Thank you for the feedback! You’re right, the current changes assume pnpm as the package manager. To make this more flexible, I’ll update the Dockerfiles and CI scripts to detect and use the user’s preferred package manager (npm, yarn, or pnpm). I’ll add logic to check for a lockfile (package-lock.json, yarn.lock, or pnpm-lock.yaml) and use the corresponding tool. I’ll also update the documentation to clarify this behavior. |
…etection; update docs
❌ The current Mergify configuration is invalidDetails
|
|
This update adds support for all major Node.js package managers (npm, yarn, pnpm) in Dockerfiles and CI workflows. The build system now automatically detects the correct package manager based on the presence of a lockfile (yarn.lock, package-lock.json, or pnpm-lock.yaml) and uses the appropriate install/run commands. Documentation has been updated to explain the new detection logic. |
Mattral
left a comment
There was a problem hiding this comment.
May I ask for a review on what could be improved?
|
You're welcome! Still really appreciate you pushing cdk-nextjs forward :) I'll close the related issue. |
Replaces Corepack installs with direct pnpm installs in Dockerfiles and adds a GitHub Actions workflow to build the affected images as a smoke test.
related issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.