Skip to content

fix: lambda url permissions and turbo for NexjsGlobalFunctions #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bestickley merged 3 commits into from
Feb 23, 2026
Merged

fix: lambda url permissions and turbo for NexjsGlobalFunctions #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e78adef
fix: lambda url permissions for cloudfront
bestickley Feb 23, 2026
4993bd6
fix: enable turbo on nextjs global functions
bestickley Feb 23, 2026
a8422fc
chore: self mutation
invalid-email-address Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion .projenrc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,14 @@ const project = new awscdk.AwsCdkConstructLibrary({
awsSdkConnectionReuse: false, // doesn't exist in AWS SDK JS v3
},
projenCommand: "pnpm dlx projen",
gitignore: [".idea", ".DS_Store", "*.drawio.bkp", "ash_output", "~$*.xlsx"],
gitignore: [
".idea",
".DS_Store",
"*.drawio.bkp",
"ash_output",
"~$*.xlsx",
".kiro",
],
projenrcTs: true,
eslintOptions: {
prettier: true,
Expand Down
6 changes: 4 additions & 2 deletions src/lambdas/assets-deployment/fs-to-s3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ export async function fsToS3(props: FsToS3Props) {
});
let body: string | ReadStream;
if (
path.includes(".next/static/chunks/main-app-") &&
nextjsType === NextjsType.GLOBAL_FUNCTIONS
path.includes(".next/static/chunks/main-app-") ||
(path.startsWith("turbopack-") &&
path.endsWith(".js") &&
nextjsType === NextjsType.GLOBAL_FUNCTIONS)
) {
// see src/lambdas/assets-deployment/patch-fetch.js for why this is needed
const mainAppFileContent = readFileSync(path);
Expand Down
4 changes: 4 additions & 0 deletions src/nextjs-compute/nextjs-functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { join } from "path/posix";
import { Duration } from "aws-cdk-lib";
import { ServicePrincipal } from "aws-cdk-lib/aws-iam";
import {
DockerImageCode,
DockerImageFunction,
Expand Down Expand Up @@ -46,6 +47,9 @@ export class NextjsFunctions extends Construct {
this.props = props;
this.function = this.createFunction();
if (props.nextjsType === NextjsType.GLOBAL_FUNCTIONS) {
this.function.grantInvoke(
new ServicePrincipal("cloudfront.amazonaws.com"),
);
this.functionUrl = this.function.addFunctionUrl({
authType: FunctionUrlAuthType.AWS_IAM,
invokeMode: InvokeMode.RESPONSE_STREAM,
Expand Down
Loading