Skip to content

fix: ensure the admin role stabilizes for self-managed stacksets #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinjlowm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: ensure the admin role stabilizes for self-managed stacksets #678

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52509b8
fix: ensure the admin role stabilizes for self-managed stacksets
martinjlowm Dec 22, 2024
23a9c94
chore: add test for ensuring DependsOn is set with the created AdminRole
martinjlowm Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/stackset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,10 @@ export class StackSet extends Resource implements IStackSet {
stackInstancesGroup: Lazy.any({ produce: () => { return this.stackInstances; } }),
});

if (this._role) {
stackSet.node.addDependency(this._role);
}

// the file asset bucket deployment needs to complete before the stackset can deploy
for (const fileAssetResourceName of fileAssetResourceNames) {
const fileAssetResource = scope.node.tryFindChild(fileAssetResourceName);
Expand Down