-
-
Notifications
You must be signed in to change notification settings - Fork 54
add methods #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add methods #172
Conversation
- add remove_handler to stop listen to event - add expect_response, expect_response as in playwright-python - add wait_for_page_load to wait until page loaded
Co-authored-by: Stephan Lensky <[email protected]>
Hello, thanks for your contribution. It looks like the code is not properly formatted (see lint) and tests are not passing yet. Also, I saw you started to add some error types. We can talk about it, we already defined some at https://github.com/cdpdriver/kdriver/tree/main/core/src/commonMain/kotlin/dev/kdriver/core/exceptions, so it could be great to discuss about it to keep a similar api in both projects (I'm open for changes in kdriver's exceptions as well) I will take some time to review your changes more precisely and give feedbacks about them. |
|
This pull request has been marked stale because it has been open for 30 days with no activity. If there is no activity within 7 days, it will be automatically closed. |
Sorry I'm in a rush at work; I'll take some time to review it later |
Description
tab.set_content
methods to Set content to pagetab.expose_function
The method adds a function called name on the window object. When called, the function executes callback and returns a Promise which resolves to the return value of callback.tab.expose_bindings
The method adds a function called name on the window object. When called, the function executes callback and returns a Promise which resolves to the return value of callback. If the callback returns a Promise, it will be awaited.tab.add_script_tag
The method adds a script tag to page.tab.add_style_tag
The method adds a style tag to page.Pre-merge Checklist
./scripts/format.sh
and./scripts/lint.sh
scripts. My code is properly formatted and has no linting errors.[Unreleased]
section.