Skip to content

Conversation

3mora2
Copy link
Contributor

@3mora2 3mora2 commented Jul 24, 2025

Description

  • Add tab.set_content methods to Set content to page
  • Add tab.expose_function The method adds a function called name on the window object. When called, the function executes callback and returns a Promise which resolves to the return value of callback.
  • Add tab.expose_bindings The method adds a function called name on the window object. When called, the function executes callback and returns a Promise which resolves to the return value of callback. If the callback returns a Promise, it will be awaited.
  • Add tab.add_script_tag The method adds a script tag to page.
  • Add tab.add_style_tag The method adds a style tag to page.

Pre-merge Checklist

  • I have described my change in the section above.
  • I have ran the ./scripts/format.sh and ./scripts/lint.sh scripts. My code is properly formatted and has no linting errors.
  • I have added my change to CHANGELOG.md under the [Unreleased] section.

@3mora2 3mora2 requested a review from a team as a code owner July 24, 2025 08:37
@nathanfallet
Copy link
Member

Hello, thanks for your contribution. It looks like the code is not properly formatted (see lint) and tests are not passing yet.

Also, I saw you started to add some error types. We can talk about it, we already defined some at https://github.com/cdpdriver/kdriver/tree/main/core/src/commonMain/kotlin/dev/kdriver/core/exceptions, so it could be great to discuss about it to keep a similar api in both projects (I'm open for changes in kdriver's exceptions as well)

I will take some time to review your changes more precisely and give feedbacks about them.

@3mora2
Copy link
Contributor Author

3mora2 commented Jul 27, 2025

set_content , add_script_tag, add_style_tag from pyppeteer
expose_bindings from playwright

Copy link
Contributor

This pull request has been marked stale because it has been open for 30 days with no activity. If there is no activity within 7 days, it will be automatically closed.

@nathanfallet
Copy link
Member

Sorry I'm in a rush at work; I'll take some time to review it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants