Tree: invoke _ev_routing() on relaunch and add tests #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EventHandler._ev_routing() has been defined since CS 1.6 or so, but was never called. It can be used by the user program to get notified for tree related propagation events. For now it is relatively simple and we only generate "reroute" events when a gateway is failing and commands are tentatively redistributed to other gateways. Note that with this change, the parents nodes need to be upgraded first, otherwise they won't understand the new RoutingMessage coming from the gateways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventHandler._ev_routing() has been defined since CS 1.6 or so, but was never called. It can be used by the user program to get notified for tree related propagation events. For now it is relatively simple and we only generate "reroute" events when a gateway is failing and commands are tentatively redistributed to other gateways.
Note that with this change, the parents nodes need to be upgraded first, otherwise they won't understand the new RoutingMessage coming from the gateways.