Package: allow any kind of tests #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replace the '*.sh' iterator with a method which lookup every file with the execution permission inside the 'tests' folder of a Rift package. This allow any kind to be ran : shell, Python, binary...
|
Comments from Gerrit change 14688 were taken into account |
valeriyoann
approved these changes
Sep 2, 2025
| logging.info('%s not found, this package has no custom tests', self.testsdir) | ||
| return | ||
|
|
||
| for filepath in os.scandir(self.testsdir): |
There was a problem hiding this comment.
suggest: handling tests in sub-directories would be nice too, in case that ever happens. A simple recursive call should be enough.
| return | ||
|
|
||
| for filepath in os.scandir(self.testsdir): | ||
| if os.access(filepath, os.X_OK): |
There was a problem hiding this comment.
minor: if for any reason there are sub-directories, this condition will most likely be valid, as most directories as execution rights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replace the '*.sh' iterator with a method which lookup every file with the execution permission inside the 'tests' folder of a Rift package. This allow any kind to be ran : shell, Python, binary...