graph: auto rebuild/validation of reverse deps #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the graph modules with class to handle a graph of reverse dependencies between packages in a Rift project. When a package is built, especially when its version has changed, it is important to verify that it does not break build and tests of other packages that depends on it (aka. reverse dependencies). With this new feature, as soon as dependency_tracking option is enabled in project configuration, the graph of reverse dependencies is automatically created with rift build and validate actions, unless --skip-deps option is set on command line. Dependencies are either found in packages info.yaml metadata file or by parsing subpackages (including their provides) and build requirements out of RPM spec files as a fallback. Rift then solves the reverse dependencies of the packages provided by users with build and validate actions to determine the packages that should be rebuilt or validated consequently. Unit tests are added to validate the code introduced for this feature.
rezib
requested review from
qa-cea and
valeriyoann
and removed request for
qa-cea
valeriyoann
requested changes
Oct 8, 2025
Apply fixes requested and suggested during review.
Collaborator
Author
|
Thank you @valeriyoann for your detailed review! I think I have covered all points. |
valeriyoann
approved these changes
Oct 9, 2025
qa-cea
approved these changes
Oct 27, 2025
lib/rift/Controller.py
Outdated
| mock = Mock(config, arch, config.get('version')) | ||
|
|
||
| for repo in repos.all: | ||
| logging.debug("Mock with repo %s: %s", repo.name, repo.url) |
Collaborator
There was a problem hiding this comment.
question: est ce que ça serait pas mieux d'avoir un message de debug plus clair ?
"init mock chroot with..." par exemple
Collaborator
Author
There was a problem hiding this comment.
Oops, this was actually a debugging leftover 🫣 I removed it in a290124.
qa-cea
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the graph modules with class to handle a graph of reverse dependencies between packages in a Rift project.
When a package is built, especially when its version has changed, it is important to verify that it does not break build and tests of other packages that depends on it (aka. reverse dependencies).
With this new feature, as soon as dependency_tracking option is enabled in project configuration, the graph of reverse dependencies is automatically created with rift build and validate actions, unless --skip-deps option is set on command line. Dependencies are either found in packages info.yaml metadata file or by parsing subpackages (including their provides) and build requirements out of RPM spec files as a fallback.
Rift then solves the reverse dependencies of the packages provided by users with build and validate actions to determine the packages that should be rebuilt or validated consequently.
Unit tests are added to validate the code introduced for this feature.