Fix gerrit spec file analysis with absolute path #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In gerrit action, compare the filepath extracted from patch with the relative path of package specfile. The package specfile could be an absolute path, in which case gerrit action never match the condition and the spec file is never analyzed despite the validating review.
valeriyoann
reviewed
Oct 8, 2025
valeriyoann
approved these changes
Oct 21, 2025
qa-cea
reviewed
Oct 27, 2025
There was a problem hiding this comment.
The PR look good to me, but we are going to deprecate Gerrit soon so I don't think we will merge this @valeriyoann ?
|
Since the code is there, and we never know what may happen in the future, might as well merge it I'd say. |
|
Do you want me to rebase this PR on current master in order to fix detected conflict? |
qa-cea
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Package specfile attribute is an absolute path. For comparison with paths extracted from patchs, it must be converted to relative path to have a chance to match.
Some unit tests for gerrit actions are introduced. These tests can be used to raise the bug before the fix is applied.