Annex: accept new line in pointer detection logic #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezib
requested review from
qa-cea and
valeriyoann
and removed request for
qa-cea
qa-cea
reviewed
Jan 23, 2026
Collaborator
qa-cea
left a comment
qa-cea
left a comment
There was a problem hiding this comment.
Have you encountered this problem often? Pointers generated by Rift should not contain line breaks.
Collaborator
Author
Personally never! But @valeriyoann did and he thinks Rift should permit this. |
qa-cea
approved these changes
Jan 23, 2026
valeriyoann
approved these changes
Jan 27, 2026
lib/rift/Annex.py
Outdated
| if meta.st_size in (32, 64): | ||
| # MD5 (32) or SHA3 256 (64). Also accept one or two more bytes to accept | ||
| # trailing new line and carriage return characters. | ||
| if meta.st_size in (32, 33, 34, 64, 65, 66): |
Contributor
There was a problem hiding this comment.
suggest: I think it'd be easier to do it in reverse
with open:
identifier = ...
if identifier.size() not in (32, 64):
return False
return all(...)
What do you think ?
Collaborator
Author
There was a problem hiding this comment.
Sure, it makes the logic more simple. Done in 3137f79.
| temp_file = make_temp_file(correct_identifier) | ||
| self.assertTrue(Annex.is_pointer(temp_file.name)) | ||
|
|
||
| def test_is_pointer_valid_identifier_with_carriage_return(self): |
Contributor
There was a problem hiding this comment.
suggest: add the same test for spaces
Also add test with trailing whitespace.
rezib
force-pushed
the
pr/is_pointer-nl
branch
from
fc54c3c to
3137f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.