VM: check remote image Last-Modified header #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezib
force-pushed
the
pr/vm-download-check
branch
from
f2867ca to
8f372c2
Compare
Collaborator
Author
valeriyoann
approved these changes
Jan 27, 2026
lib/rift/utils.py
Outdated
|
|
||
| def last_modified(url): | ||
| """ | ||
| Return number of seconds since epoch of Last-Modified header for the given |
Contributor
There was a problem hiding this comment.
suggest: simplify the explanation to return the mtime of the URL using the Last-Modified header (and keep the other 2 sentences)
When starting VM with a remote image and local copy is present, try to send HEAD request on remote URL to get its Last-Modified header for comparison with local copy mtime on filesystem. If mtime is older than remote URL Last-Modified, remove local copy and download latest VM image.
rezib
force-pushed
the
pr/vm-download-check
branch
from
8f372c2 to
8b6f9c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting VM with a remote image and local copy is present, try to send HEAD request on remote URL to get its Last-Modified header for comparison with local copy mtime on filesystem (converted in UTC timezone). If mtime is older than remote URL Last-Modified, remove local copy and download latest VM image.