Skip to content

Update vm_mngr.c #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qihuanpiaoliu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update vm_mngr.c #1052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions miasm/jitter/vm_mngr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ static uint64_t memory_page_read(vm_mngr_t* vm_mngr, unsigned int my_size, uint6
}
switch(my_size){
case 8:
ret = ret;
/*ret = ret*/;
Copy link
Contributor

@XVilka XVilka Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed instead of commented I think?

break;
case 16:
ret = set_endian16(vm_mngr, (uint16_t)ret);
Expand Down Expand Up @@ -302,7 +302,7 @@ static void memory_page_write(vm_mngr_t* vm_mngr, unsigned int my_size,
switch(my_size){

case 8:
src = src;
/*src = src*/;
break;
case 16:
src = set_endian16(vm_mngr, (uint16_t)src);
Expand Down Expand Up @@ -926,7 +926,7 @@ void hexdump(char* m, unsigned int l)
if (!(i%0x10) && i){
last = i;
printf(" ");
for (j=-0x10;j<0;j++){
for (j=-0x10;(int)j<0;j++){
Copy link
Contributor

@serpilliere serpilliere Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @qihuanpiaoliu !
Thank you for the fix.
For the last one, maybe we can declare an "int" (signed) k for example, and use it here to avoid the warning instead of casting j as unsigned. What do you thinl of this?

if (isprint(m[i+j])){
printf("%c", m[i+j]);
}
Expand Down