types: add stronger types and helpers for inspecting Paths and Path derivatives#131
Open
patjakdev wants to merge 1 commit intocedar-policy:mainfrom
Open
types: add stronger types and helpers for inspecting Paths and Path derivatives#131patjakdev wants to merge 1 commit intocedar-policy:mainfrom
patjakdev wants to merge 1 commit intocedar-policy:mainfrom
Conversation
patjakdev
force-pushed
the
patjak/namespace-helpers
branch
2 times, most recently
from
1e1a633 to
87af386
Compare
…erivatives Now, instead of passing types.Paths around all over the place in the schema code, we can know that we've got a Namespace or a commonType or a EntityType and the code becomes easier to understand (IMO). The new methods on Path and EntityType may also help cedar-go users write more understandable code. Signed-Off-By: Patrick Jakubowski <patrick.jakubowski@strongdm.com>
patjakdev
force-pushed
the
patjak/namespace-helpers
branch
from
87af386 to
4aa1601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Now, instead of passing types.Paths around all over the place in the schema code, we can know that we've got a Namespace or a commonType or a EntityType and the code becomes easier to understand (IMO).
The new methods on Path and EntityType may also help cedar-go users write more understandable code.