Conversation
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
…ke command? Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
cedar-lean/Cedar/Data/LT.lean
Outdated
| exact List.slt_trans h₃ h₆ | ||
|
|
||
| theorem List.lt_asymm [LT α] [StrictLT α] {xs ys : List α} : | ||
| theorem List.lt_asymm' [LT α] [StrictLT α] [Cedar.Data.DecidableLT α] {xs ys : List α} : |
There was a problem hiding this comment.
I'm guessing this renaming was necessary to avoid a conflict with a newly introduced theorem in Lean?
Can we rename it to List.slt_asymm to be consistent with List.slt_trans (which we also had to rename because of a conflict in the last update)?
There was a problem hiding this comment.
sure. What does the s stand for?
| apply List.lt_asymm' | ||
| transitive a b c := by | ||
| simp [LT.lt, Name.lt] | ||
| simp only [LT.lt] |
There was a problem hiding this comment.
Curious why we need to consecutive simp onlys here. Stylistic choice or Lean does the wrong thing if we use a single simp only that calls both sets of theorems?
Edited to add: this is not a blocker, just curiosity :)
There was a problem hiding this comment.
Yes, if we combine it all then Lean throws maximum recursion depth has been reached
There was a problem hiding this comment.
I think that LT.lt and Name.lt recurse infinitely with each other, so those are the two that needed separating
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Biggest change for us is (quoting from the Lean changelog):
Separately, Lean introduced its own
DecidableLT. For now, to get things working, I kept ourDecidableLTand just qualified it asCedar.Data.DecidableLTwhen ambiguous. In a future PR we can look at replacing ourDecidableLTwith the Lean one.