Merged
Conversation
Signed-off-by: John Kastner <jkastner@amazon.com>
john-h-kastner-aws
force-pushed
the
tpe-proof-tweaks
branch
from
874776d to
f50dc34
Compare
cdisselkoen
approved these changes
Mar 6, 2026
| cases res <;> simp [Except.toOption] | ||
|
|
||
| public theorem do_to_option_none {ε α β} {res : Except ε α} {f : α → Except ε β} : | ||
| res.toOption = none → (do let x ← res; f x).toOption = none |
Contributor
There was a problem hiding this comment.
nit: should those have toOption instead of to_option?
Contributor
Author
There was a problem hiding this comment.
we're slightly inconsistent on this. I think generally yes, but existing theorems in this file use to_option
victornicolet
approved these changes
Mar 9, 2026
Signed-off-by: John Kastner <jkastner@amazon.com>
Signed-off-by: John Kastner <jkastner@amazon.com>
victornicolet
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move some existing TPE helper lemmas around